libwebsocket: add missing $webSockets dependency#26318
Open
subhaushsingh wants to merge 2 commits intoemscripten-core:mainfrom
Open
libwebsocket: add missing $webSockets dependency#26318subhaushsingh wants to merge 2 commits intoemscripten-core:mainfrom
subhaushsingh wants to merge 2 commits intoemscripten-core:mainfrom
Conversation
subhaushsingh
force-pushed
the
fix-websocket-deps
branch
2 times, most recently
from
3c31983 to
bb5aca2
Compare
subhaushsingh
force-pushed
the
fix-websocket-deps
branch
from
bb5aca2 to
332a885
Compare
Author
|
@sbc100 I've added a regression test for emscripten_websocket_new to cover the missing $webSockets dependency issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
emscripten_websocket_newuses$webSocketsbut does not declare it as a dependency.In non-MAIN_MODULE builds, this allows $webSockets to be removed by dead code elimination, leading to a runtime error.
This patch adds:
emscripten_websocket_new__deps: ['$webSockets'],
to ensure $webSockets is retained when emscripten_websocket_new is linked.
This restores correct behavior without requiring -sMAIN_MODULE=1.
Fixes: #26310